Skip to content

fix: correct environment variable name from ParticipantDemographicDataServiceURL - ProcessNemsUpdate function#1449

Merged
SamAinsworth-NHS merged 3 commits intomainfrom
Fix/pds-participant-deserialisation-and-mock-mismatch-issue
Aug 11, 2025
Merged

fix: correct environment variable name from ParticipantDemographicDataServiceURL - ProcessNemsUpdate function#1449
SamAinsworth-NHS merged 3 commits intomainfrom
Fix/pds-participant-deserialisation-and-mock-mismatch-issue

Conversation

@SamAinsworth-NHS
Copy link
Copy Markdown
Contributor

Description

Fixed configuration mismatch in ProcessNemsUpdate terraform files where the environment variable name ParticipantDemographicDataServiceURL was changed to DemographicDataServiceURL to match what the code expects in ProcessNemsUpdateConfig.cs. This resolves the System.ArgumentNullException: No URL was provided when registering DataService of type Model.ParticipantDemographic error that was occurring during function startup.

Context

The ProcessNemsUpdate function was failing to start in Azure with the error "No URL was provided when registering DataService of type Model.ParticipantDemographic" because there was a naming mismatch between:

  • Code configuration: Expected DemographicDataServiceURL
  • Terraform configuration: Provided ParticipantDemographicDataServiceURL

This prevented the dependency injection container from properly registering the IDataServiceClient<ParticipantDemographic> service with its required URL.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

…aServiceURL to DemographicDataServiceURL in ProcessNemsUpdate terraform configuration
@SamAinsworth-NHS SamAinsworth-NHS changed the title fix: correct environment variable name from ParticipantDemographicDat… fix: correct environment variable name from ParticipantDemographicDataServiceURL - ProcessNemsUpdate function Aug 8, 2025
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as ready for review August 8, 2025 16:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Unit Test Results

✔️ Tests 725 / 725 - passed in 10.7s
📝 Coverage 56.01%
📏 3940 / 6916 lines covered 🌿 931 / 1780 branches covered
🔍 click here for more details

✏️ updated for commit 075e02f

@sonarqubecloud
Copy link
Copy Markdown

@SamAinsworth-NHS SamAinsworth-NHS added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit c7402ea Aug 11, 2025
28 checks passed
@SamAinsworth-NHS SamAinsworth-NHS deleted the Fix/pds-participant-deserialisation-and-mock-mismatch-issue branch August 11, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants