Skip to content

fix: handling not found in pds func#1447

Merged
SamRobinson75684 merged 8 commits intomainfrom
fix/DTOSS-10515-Handling-not-found-in-pds-func
Aug 8, 2025
Merged

fix: handling not found in pds func#1447
SamRobinson75684 merged 8 commits intomainfrom
fix/DTOSS-10515-Handling-not-found-in-pds-func

Conversation

@SamRobinson75684
Copy link
Copy Markdown
Contributor

@SamRobinson75684 SamRobinson75684 commented Aug 8, 2025

Description

there are is more one function that needs to call PDS to check on the data that PDS has so to make things easier we have decided that it would be best if the PDS function manages what happens on error response returned.

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10515

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

sudipnhs
sudipnhs previously approved these changes Aug 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Unit Test Results

✔️ Tests 732 / 732 - passed in 13.1s
📝 Coverage 56.03%
📏 3939 / 6914 lines covered 🌿 931 / 1778 branches covered
🔍 click here for more details

✏️ updated for commit a101923

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 8, 2025

@SamRobinson75684 SamRobinson75684 added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit 5db5f34 Aug 8, 2025
64 checks passed
@SamRobinson75684 SamRobinson75684 deleted the fix/DTOSS-10515-Handling-not-found-in-pds-func branch August 8, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants