Skip to content

fix: pds function now maganges all responses from the 3rd party pds API#1445

Closed
SamRobinson75684 wants to merge 6 commits intomainfrom
Fix/DTOSS-10515-Handling-not-found-in-pds-func
Closed

fix: pds function now maganges all responses from the 3rd party pds API#1445
SamRobinson75684 wants to merge 6 commits intomainfrom
Fix/DTOSS-10515-Handling-not-found-in-pds-func

Conversation

@SamRobinson75684
Copy link
Copy Markdown
Contributor

Description

there are is more one function that needs to call PDS to check on the data that PDS has so to make things easier we have decided that it would be best if the PDS function manages what happens on error response returned.

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10515

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Unit Test Results

✔️ Tests 732 / 732 - passed in 12.4s
📝 Coverage 56.03%
📏 3939 / 6914 lines covered 🌿 931 / 1778 branches covered
🔍 click here for more details

✏️ updated for commit 35d65c7

@SamRobinson75684 SamRobinson75684 changed the title pds function now maganges all responses from the 3rd party pds API fix: pds function now maganges all responses from the 3rd party pds API Aug 8, 2025
sudipnhs

This comment was marked as resolved.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants