Skip to content

feat: DTOSS-10479 add nems poison container and logic#1440

Merged
SamAinsworth-NHS merged 29 commits intomainfrom
feat/DTOSS-10479-Add-Nems-Poison-Container
Aug 13, 2025
Merged

feat: DTOSS-10479 add nems poison container and logic#1440
SamAinsworth-NHS merged 29 commits intomainfrom
feat/DTOSS-10479-Add-Nems-Poison-Container

Conversation

@SamAinsworth-NHS
Copy link
Copy Markdown
Contributor

@SamAinsworth-NHS SamAinsworth-NHS commented Aug 7, 2025

Description

This PR introduces the NemsPoisonContainer environment variable and configuration property for the ProcessNemsUpdate Azure Function. Failed Nems PDS updates will be copied into this container, similar to inbound-poison.

Context

Before this change any failures would only be logged in App Insights - this ensures it's easy to replay failed updates.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 12, 2025

Unit Test Results

✔️ Tests 778 / 778 - passed in 66s
📝 Coverage 57.23%
📏 4208 / 7232 lines covered 🌿 991 / 1852 branches covered
🔍 click here for more details

✏️ updated for commit 987b401

…om:NHSDigital/dtos-cohort-manager into feat/DTOSS-10479-Add-Nems-Poison-Container
@SamAinsworth-NHS SamAinsworth-NHS marked this pull request as ready for review August 12, 2025 14:52
@sonarqubecloud
Copy link
Copy Markdown

@SamAinsworth-NHS SamAinsworth-NHS added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit 0331745 Aug 13, 2025
54 checks passed
@SamAinsworth-NHS SamAinsworth-NHS deleted the feat/DTOSS-10479-Add-Nems-Poison-Container branch August 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants