Skip to content

feat: block phase 2 pds#1423

Merged
MWClayson-NHS merged 35 commits intomainfrom
Block-Phase-2-PDS
Aug 11, 2025
Merged

feat: block phase 2 pds#1423
MWClayson-NHS merged 35 commits intomainfrom
Block-Phase-2-PDS

Conversation

@MWClayson-NHS
Copy link
Copy Markdown
Contributor

@MWClayson-NHS MWClayson-NHS commented Aug 6, 2025 •
edited
Loading

Description

Adds the end to end block functionality

  • Creates a Stub for the ManageNemsSubscription for testing
  • Creates a BlockParticipantHandler class which manages the business process for blocking
  • Creates a new endpoint for the GetParticipantDetails used to validate the participant is the correct one to be blocked
  • Adds a SendPost method in HTTPClientFunction to add query parameters
  • New HttpStubUtilities Class

Context

DTOSS-7486
DTOSS-6969
DTOSS-3889
DTOSS-3887

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 6, 2025 •
edited
Loading

Unit Test Results

✔️ Tests 734 / 734 - passed in 12s
📝 Coverage 56.04%
📏 4084 / 7187 lines covered 🌿 974 / 1838 branches covered
🔍 click here for more details

✏️ updated for commit efaf6b6

MWClayson-NHS and others added 3 commits August 6, 2025 14:16
@MWClayson-NHS
tests part one
bdd0ddd
@MWClayson-NHS @SamAinsworth-NHS
Correct Logging from PR Comment
b8cb0f1 
Co-authored-by: Sam Ainsworth <samuel.ainsworth1@nhs.net>
@MWClayson-NHS
Addressing comments
2379d50
@MWClayson-NHS MWClayson-NHS marked this pull request as ready for review August 7, 2025 13:28
alex-clayton-1
alex-clayton-1 reviewed Aug 7, 2025
View reviewed changes
Comment thread ...rtManager/src/Functions/ParticipantManagementServices/UpdateBlockedFlag/UpdateBlockedFlag.cs
Comment thread ...rtManager/src/Functions/ParticipantManagementServices/UpdateBlockedFlag/UpdateBlockedFlag.cs Outdated
SamAinsworth-NHS
SamAinsworth-NHS previously approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@SamAinsworth-NHS SamAinsworth-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with suggestions as I don't think any of them are blockers

alex-clayton-1
alex-clayton-1 previously approved these changes Aug 7, 2025
View reviewed changes
@MWClayson-NHS MWClayson-NHS enabled auto-merge August 7, 2025 14:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 11, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
66.8% Coverage on New Code
5.3% Duplication on New Code

See analysis details on SonarQube Cloud

@MWClayson-NHS MWClayson-NHS added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit e0f7e3d Aug 11, 2025
54 checks passed
@MWClayson-NHS MWClayson-NHS deleted the Block-Phase-2-PDS branch August 11, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Warren-Pitterson Warren-Pitterson Warren-Pitterson left review comments

+3 more reviewers

@adamsheldon1 adamsheldon1 adamsheldon1 approved these changes

@alex-clayton-1 alex-clayton-1 alex-clayton-1 approved these changes

@SamAinsworth-NHS SamAinsworth-NHS SamAinsworth-NHS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MWClayson-NHS @adamsheldon1 @Warren-Pitterson @alex-clayton-1 @SamAinsworth-NHS @Joseph2910