Draft
Conversation
DWolfsNHS
force-pushed
the
feature/GPCAPIM-395_Local_PDS_INT_Integration
branch
2 times, most recently
from
34f784a to
c9b0c85
Compare
DWolfsNHS
force-pushed
the
feature/GPCAPIM-395_Local_PDS_INT_Integration
branch
from
c9b0c85 to
63b4f84
Compare
…t variables - Remove unused MTLS session manager tests - Simplify session manager test by removing mock for secret retrieval - Update environment variable assertions for consistency
…coding for correct path
- Replace APIM environment variables with PDS equivalents - Remove default values for sensitive keys in Dockerfile
- Add new environment variables for APIM token URL, expiry threshold, and client timeout - Update PDS API secret handling to decode from base64 - Modify PDS client to use environment variable for PDS URL - Ensure environment variables are sourced in the app's environment script
- Consolidate environment variable handling for 'int' and 'PDS_int' - Ensure correct API token and secret retrieval for both environments
- Add function to retrieve APIM token URL based on environment - Update env.sh to source APIM_auth.sh and use get_apim_token_url
- Remove auth_token parameter from patient search tests - Update mock requests to use _make_get_request method - Ensure consistent client instantiation across tests
- Change mocked PDS client method to use _make_get_request - Remove auth token parameter from _get_pds_details call - Ensure controller uses the provided custom PDS URL
- Normalize line endings for PDS API secret in environment values - Update test values to use base64 encoding for PDS API secret - Adjust environment variable names for consistency with PDS integration
- Set CLIENT_TIMEOUT to a fixed value of 30s - Set APIM_TOKEN_EXPIRY_THRESHOLD to a fixed value of 30s
- Introduced a new environment variable for PDS URL in the test setup - Marked the addition with a TODO comment for further clarification
- Added SDS_URL to the test environment variables
… logic - Introduced APIMAppAuthStub to simulate authentication requests - Updated _make_session_post to handle stubbed responses - Modified test cases to use the new stub for authentication - Enhanced session management in the stub for better testing - Adjusted contract tests to verify stub behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.