patch superlu memory query#221
Open
Copper280z wants to merge 2 commits intoMystranSolver:devfrom
Open
Conversation
Superlu calculates memory usage in bytes as an int, this can overflow for many valid cases. There's no need to use a signed integer for these, so the real change is on line 102 to use a size_t instead of int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superlu uses a signed into to calculate the memory requirements. This leads to a signed overflow for any memory usage above ~4GB and there's no case for a memory estimate needing a signed integer so I patched the calculation to use a
size_tinstead (on line 102) and added it to the superlu patch folder.