Improvement - Add TransferModule#ping validation & increase PingRequest timeout to 10s - #302
Merged
Merged
Conversation
ItsNature
added
type: Documentation
ItsNature
changed the title
TransferModule#ping validation & increase PingRequest timeout to 10s`TransferModule#ping validation & increase PingRequest timeout to 10s
TrentinTheKid
approved these changes
Jul 13, 2026
ItsNature
force-pushed
the
improvement/transfer-ping
branch
from
August 10, 2026 21:04
e7c8951 to
ef80ce1
Compare
Merged
ItsNature
added a commit
that referenced
this pull request
Aug 19, 2026
* Deploy as `1.2.9-SNAPSHOT` * Feature - Height Limit Module (#300) * Height Limit Module * Add default height limit config entry, more callouts & update example * Document snake_case custom data keys (#301) * Add `TransferModule#ping` validation & increase `PingRequest` timeout to 10s (#302) * example(internal): npc visibility tracking (#303) * Feature - Inventory & Chat Buttons (#304) * Inventory & Chat Buttons # Conflicts: # gradle/libs.versions.toml * Add default chat & inventory buttons config option * Add button docs * Add button images to docs * Update inventory.mdx * Update chat.mdx * Remove temp gradle publish --------- Co-authored-by: Trentin <25537885+TrentinTheKid@users.noreply.github.com> * Add `NametagVisibilityOverride` to `Nametag` (#305) # Conflicts: # gradle/libs.versions.toml * Sync LunarClient Mods & Options (#307) * Sync LunarClient Mods & Options * Update version tags to 1.2.9 --------- Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com> * Bump to 1.2.9 (#308) --------- Co-authored-by: Trentin <25537885+TrentinTheKid@users.noreply.github.com> Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Description:
Fixes the server ping round-trip failing whenever a request contains an unreachable address. The client pings every address and reports unreachable ones as
TIMED_OUT. Additionally, requests with more than 10 server IPs were silently dropped by the client and only surfaced as a generic timeout.Changes:
PingRequestoverrides the timeout to 10s, giving ping round-trips the headroom they need.TransferModuleImpl#pingnow fails fast withIllegalArgumentExceptionwhen the request contains no server IPs or more thanTransferModule.MAX_PINGS_PER_PACKET(10), instead of sending a request the client can't honor.Review Request Checklist
feature/add-module&bugfix/fix-issue)