This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a broken link in the documentation section of the MHAttention module by updating the URL for the Self-Attention visualization.
- Updated the Self-Attention link in the documentation comments.
- Ensured the new link directs to the correct page for visualization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
===================================
Coverage 69% 69%
===================================
Files 2 2
Lines 441 441
===================================
Hits 306 306
Misses 135 135 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes broken link and so blocked CI
This pull request includes a small but important update to a URL in the
MHAttention.pyfile. The change updates a link to a more accurate source for visualizing self-attention mechanisms.course_UvA-DL/05-transformers-and-MH-attention/MHAttention.py: Updated the URL for "Illustrated: Self-Attention" to a more appropriate link on Medium.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃