fix(macos): distinguish no-audio startup and allow cancelled recorder cleanup - #61
Closed
LeonardNJU wants to merge 1 commit into
Closed
fix(macos): distinguish no-audio startup and allow cancelled recorder cleanup#61LeonardNJU wants to merge 1 commit into
LeonardNJU wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Owner
Author
|
Integrated into master in dddc37a with the current delayed-startup UI preserved. Local macOS 12/12 tests and native contracts passed; the installed signed combined build is 5.0.8+audio.dddc37a. A separate controlled comparison restored both AVAudioRecorder and VocoType capture by stopping only system-audio-spectrum; coreaudiod PID stayed unchanged. Details and limitations are recorded in docs/diagnostics/macos-audio-startup.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix confirmed macOS recording-state and cancellation hazards found while investigating another zero-audio startup incident. This is not a claim that the trigger of the system audio-service stall is permanently solved.
Evidence and validation
The installed Apple-signed 5.0.8 InputMethod/Settings/recorder signatures and audio-input entitlements verified. Actual F9 requests were authorized by TCC. The signed Settings capture reported authorization=authorized but zero audio blocks after 8 seconds. The recorder was waiting in AudioOutputUnitStart / AudioDeviceStart / StartAndWaitForState. An independent AVAudioRecorder probe also reported authorized access but hung before returning from recordForDuration. A run-loop pumping experiment did not help and is not included.
HAL StartIO/Running logs printed during cancellation were accompanied by zero frames: these are not proof of successful recording or ordinary long DSP cold-start latency. The earlier diagnosis based on those messages was too strong.
A normal user-authorized coreaudiod restart restored the old installed build before this patch. The same helper then completed three one-second captures; independent AVAudioRecorder captured 48,000 frames. Recovery cannot be attributed to this patch.
5.0.8+audio.895c86e.Long-idle/sleep-wake recurrence prevention is not yet demonstrated. See
docs/diagnostics/macos-audio-startup.mdfor the evidence and recovery boundary. Windows prototype worktree and installed Linux environment are untouched.