fix(glyph): clear stale source shift scale#3493
Open
PaulHax wants to merge 1 commit intoKitware:masterfrom
Open
fix(glyph): clear stale source shift scale#3493PaulHax wants to merge 1 commit intoKitware:masterfrom
PaulHax wants to merge 1 commit intoKitware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix. Clear stale coordinate shift/scale state on glyph source VBOs when
vtkGlyph3DMapperno longer needs shift/scale normalization for glyph centers.Details
vtkGlyph3DMapperapplies shift/scale normalization to glyph center matrices for large coordinate ranges. It also applies the same transform to glyph source primitives after the basePolyDataMapperbuilds source VBOs.Previously, when a later frame no longer required center shift/scale, the mapper stopped applying the transform to center matrices but did not clear the previous transform from the source primitive CABOs. That left glyph centers and glyph source geometry using different coordinate transforms.
This updates
Glyph3DMapperto always set the source primitive shift/scale state: pass the computed shift/scale when active, otherwise passnull, nullto clear stale state.