feat(WebGPU): add vtkSkybox#3486
Merged
finetjul merged 3 commits intoKitware:masterfrom May 4, 2026
Merged
Conversation
38 tasks
daker
force-pushed
the
feat-skybox-webgpu
branch
from
24718b5 to
a829738
Compare
finetjul
reviewed
Apr 22, 2026
finetjul
reviewed
Apr 22, 2026
daker
force-pushed
the
feat-skybox-webgpu
branch
2 times, most recently
from
0ef3cbf to
6503af0
Compare
daker
force-pushed
the
feat-skybox-webgpu
branch
2 times, most recently
from
6503af0 to
890e0f8
Compare
sankhesh
approved these changes
May 1, 2026
Collaborator
sankhesh
left a comment
sankhesh
left a comment
There was a problem hiding this comment.
LGTM with a minor question
|
🎉 This PR is included in version 35.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Results
Test with https://kitware.github.io/vtk-js/examples/SkyboxViewer/index.html?fileURL=https://data.kitware.com/api/v1/file/5ae8a89c8d777f0685796bae/download&viewAPI=WebGPU
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting