Skip to content

test(exceptions): remove #[CoversClass] from exception test to fix PH… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walmir-silva merged 1 commit into from
Mar 5, 2026
Merged

test(exceptions): remove #[CoversClass] from exception test to fix PH… #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/Unit/Exception/SanitizationExceptionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@

use KaririCode\Sanitizer\Exception\InvalidRuleException;
use KaririCode\Sanitizer\Exception\SanitizationException;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;

#[CoversClass(InvalidRuleException::class)]
#[CoversClass(SanitizationException::class)]
// NOTE: #[CoversClass] is intentionally omitted for exception classes.
// In PHPUnit 12 + pcov, classes that directly extend \RuntimeException
// (a native PHP class) are reported as "not a valid target for code coverage",
// which triggers PHPUnit warnings that — with failOnWarning="true" — exit as code 1.
// Coverage for these classes is achieved transitively via SanitizerEngineTest and others.
final class SanitizationExceptionsTest extends TestCase
{
#[Test]
Expand Down