Skip to content

ci: make workflows identical to kariricode-property-inspector pattern #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walmir-silva merged 1 commit into from
Mar 5, 2026
Merged

ci: make workflows identical to kariricode-property-inspector pattern #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,11 @@ jobs:
- name: Initialize devkit (.kcode/ generation)
run: kcode init

# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
# "not a valid target" warnings for classes extending vendor base classes
- name: Patch phpunit.xml.dist
run: |
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist

# cs-fixer → phpstan (L9) → psalm → phpunit
# Exit code ≠ 0 fails the job (zero-tolerance policy)
Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,11 @@ jobs:
- name: Initialize devkit
run: kcode init

# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
# "not a valid target" warnings for classes extending vendor base classes
- name: Patch phpunit.xml.dist
run: |
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist

# Runs PHPStan Level 9 then Psalm sequentially — both must pass
- name: Run PHPStan + Psalm via kcode
Expand Down Expand Up @@ -176,14 +173,11 @@ jobs:
- name: Initialize devkit
run: kcode init

# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
# "not a valid target" warnings for classes extending vendor base classes
- name: Patch phpunit.xml.dist
run: |
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist

- name: Run tests with coverage (pcov)
run: kcode test --coverage
Expand Down
12 changes: 3 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,11 @@ jobs:
- name: Initialize devkit
run: kcode init

# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
# "not a valid target" warnings for classes extending vendor base classes
- name: Patch phpunit.xml.dist
run: |
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist

# Full pipeline: cs-fixer → phpstan (L9) → psalm → phpunit (pcov)
# Exit code ≠ 0 aborts the release — zero tolerance (ARFA 1.3)
Expand Down Expand Up @@ -90,11 +87,8 @@ jobs:
#[Sanitize('trim', 'capitalize')]
public string $name = '';

#[Sanitize('trim', 'filter.email')]
#[Sanitize('trim', 'email_filter')]
public string $email = '';

#[Sanitize(['string.truncate', ['max' => 200]])]
public string $bio = '';
}

$sanitizer = (new SanitizerServiceProvider())->createAttributeSanitizer();
Expand Down
Loading