Skip to content

perf: drop stats early to reduce memory usage #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KSXGitHub merged 1 commit into from
Jul 1, 2025
Merged

perf: drop stats early to reduce memory usage #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/fs_tree_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ where
path: root,

get_info: |path| {
let stats = match symlink_metadata(path) {
let (is_dir, size) = match symlink_metadata(path) {
Err(error) => {
reporter.report(Event::EncounterError(ErrorReport {
operation: SymlinkMetadata,
Expand All @@ -84,10 +84,16 @@ where
children: Vec::new(),
};
}
Ok(stats) => stats,
Ok(stats) => {
// `stats` should be dropped ASAP to avoid piling up kernel memory usage
let is_dir = stats.is_dir();
let size = size_getter.get_size(&stats);
reporter.report(Event::ReceiveData(size));
(is_dir, size)
}
};

let children: Vec<_> = if stats.is_dir() {
let children: Vec<_> = if is_dir {
match read_dir(path) {
Err(error) => {
reporter.report(Event::EncounterError(ErrorReport {
Expand Down Expand Up @@ -115,9 +121,6 @@ where
Vec::new()
};

let size = size_getter.get_size(&stats);
reporter.report(Event::ReceiveData(size));

Info { size, children }
},

Expand Down