Skip to content

Inplace multiplicacion for Matrix{Taylor1} and Matrix{TaylorN}#403

Merged
lbenet merged 5 commits intomasterfrom
lb/mul!_matrix
Apr 6, 2026
Merged

Inplace multiplicacion for Matrix{Taylor1} and Matrix{TaylorN}#403
lbenet merged 5 commits intomasterfrom
lb/mul!_matrix

Conversation

@lbenet
Copy link
Copy Markdown
Member

@lbenet lbenet commented Apr 6, 2026

No description provided.

lbenet and others added 2 commits April 6, 2026 11:47
…or1 or TaylorN elements

Co-authored-by: LuEdRaMo <73906617+LuEdRaMo@users.noreply.github.com>
@lbenet
Copy link
Copy Markdown
Member Author

lbenet commented Apr 6, 2026

I used the name matmultay! to still allow LinearAlgebra.mul! to work, but it admitedly is awful. Other suggestions @LuEdRaMo ?

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Status

Coverage is 92.023%lb/mul!_matrix into master. No base build found for master.

@LuEdRaMo
Copy link
Copy Markdown
Contributor

LuEdRaMo commented Apr 6, 2026

I used the name matmultay! to still allow LinearAlgebra.mul! to work, but it admitedly is awful. Other suggestions @LuEdRaMo ?

Other taylorized methods in TS do not use the suffix tay, e.g., add!, subst!, mul!, div!, etc. So, I would suggest to simply call the function matmul!. I believe there is no LinearAlgebra.matmul! and, even if it were the case, the should not be a problem as long as TS does not export that name.

@lbenet
Copy link
Copy Markdown
Member Author

lbenet commented Apr 6, 2026

There s no matmul! indeed... ok, let's use it.

@lbenet lbenet merged commit b3a7cb1 into master Apr 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants