Allow User to Specify Code Generation Visibility

[JasonBock]

Describe the solution you'd like
Right now the expectations class and classes within this class are internal. It may be desirable for a user to specify that internal types should be public as these types will be used in another library. Consider letting developers change that in the [Rock] or [RockPartial] attributes.

[mellis-ao]

Firstly, thank you for YAML that uses source generation and is AOT compatible. Found this as part of a POC for migrating from xunit to tunit for their AOT support also.

Currently looking at a migration from Moq to Rocks and this has been one of the sticking points. We have a very large project and being able to define a mock in a common "Test Utility" and accessible from other projects is very useful. I have a workaround for now but would be good to see this change implemented.

[JasonBock]

@mellis-ao you're welcome! Glad you like it.

I'm not sure what your workaround is at this point. One that I would suggest is to use [RockPartial] as you can target a class that makes the visibility of the Expectations type controllable. That said, it probably doesn't help with the nested types that are generated as I believe they're all internal (though I don't remember if I change that for [RockPartial] generation).

The plan is to have this in 10.3.0 so as long as you have a workaround....just hang on, it'll get there :)

[JasonBock]

I just checked, unfortunately [RockPartial] doesn't affect the nested types so that's not a viable solution right now.

[JasonBock]

I guess one workaround is to use [InternalsVisibleTo], maybe that's what you're doing right now @mellis-ao :)

[mellis-ao]

Have been doing something along the lines of the following to box round it, not ideal but lets me progress with the POC for now.

[RockPartial(typeof(IMyType ), BuildType.Create)]
public sealed partial class MyType
{
    [SuppressMessage("Naming", "CA1720:Identifier contains type name", Justification = "To allow compatibility with existing code.")]
    public IMyType Object => field ??= Instance();

    public void ExpectMethodCall<T>(string x, object y, T? result = default, uint times = 1)
    {
        var adornment = Setups.Method<T>(x, y).ExpectedCallCount(times);
        if (times > 0)
        {
            adornment.ReturnValue(Task.FromResult(result));
        }
    }
}

Essentially using public methods on the class to wrap the internal methods. [InternalsVisibleTo] was the other option but it would not be a small list to maintain and would potentially allow other developers to access types they should not be using from the assembly.