Update to crypton == 1.1 and replace memory package with ram - #5999
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency bounds and build inputs across multiple ledger packages to support newer cardano-crypto-class and refresh crypto/build tooling. This aligns with the stated goal of moving to crypton 1.1-compatible tooling, replacing the unmaintained memory package with ram, and updating the cardano-cls SRP pin.
Changes:
- Widen
cardano-crypto-classupper bounds to<2.7across several packages and record it in their changelogs. - Update
cardano-crypto-wrappertocrypton ^>=1.1, replacememorywithram, and bump its version/changelog accordingly. - Refresh build pins (
cabal.projectindex-state and cardano-cls SRP; Nixflake.lockinputs).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/cardano-protocol/CHANGELOG.md | Notes widened cardano-crypto-class upper bound in release notes. |
| libs/cardano-protocol/cardano-protocol.cabal | Widens cardano-crypto-class upper bound to <2.7. |
| libs/cardano-protocol-tpraos/CHANGELOG.md | Notes widened cardano-crypto-class upper bound for the unreleased version. |
| libs/cardano-protocol-tpraos/cardano-protocol-tpraos.cabal | Widens cardano-crypto-class upper bound to <2.7 (but needs version alignment with changelog). |
| libs/cardano-ledger-core/CHANGELOG.md | Notes widened cardano-crypto-class upper bound in release notes. |
| libs/cardano-ledger-core/cardano-ledger-core.cabal | Widens cardano-crypto-class upper bound to <2.7. |
| libs/cardano-ledger-binary/CHANGELOG.md | Notes widened cardano-crypto-class upper bound for the unreleased version. |
| libs/cardano-ledger-binary/cardano-ledger-binary.cabal | Widens cardano-crypto-class upper bound to <2.7 (but needs version alignment with changelog). |
| flake.lock | Updates pinned Nix inputs (CHaP and hackage.nix). |
| eras/shelley/impl/CHANGELOG.md | Notes widened cardano-crypto-class upper bound in release notes. |
| eras/shelley/impl/cardano-ledger-shelley.cabal | Widens cardano-crypto-class upper bound to <2.7. |
| eras/mary/impl/CHANGELOG.md | Notes widened cardano-crypto-class upper bound in release notes. |
| eras/mary/impl/cardano-ledger-mary.cabal | Widens cardano-crypto-class upper bound to <2.7. |
| eras/byron/crypto/CHANGELOG.md | Records crypton ^>=1.1 and memory→ram change with a version bump. |
| eras/byron/crypto/cardano-crypto-wrapper.cabal | Bumps version to 1.8.0.0, switches to crypton ^>=1.1, and replaces memory with ram. |
| cabal.project | Updates index-state and cardano-cls SRP pin/subdir list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
erikd
force-pushed
the
erikd/ram
branch
7 times, most recently
from
August 18, 2026 22:20
f543708 to
ed356ed
Compare
erikd
force-pushed
the
erikd/ram
branch
3 times, most recently
from
August 25, 2026 04:54
a45c5b8 to
6e6d164
Compare
erikd
force-pushed
the
erikd/ram
branch
5 times, most recently
from
September 3, 2026 08:03
e19a532 to
218d6c3
Compare
erikd
marked this pull request as ready for review
September 3, 2026 09:50
koslambrou
previously approved these changes
Sep 3, 2026
koslambrou
dismissed
their stale review
September 3, 2026 19:54
Should not be approved anymore. Found issue.
koslambrou
reviewed
Sep 3, 2026
koslambrou
force-pushed
the
erikd/ram
branch
2 times, most recently
from
September 4, 2026 17:05
825327e to
e99ca2a
Compare
koslambrou
force-pushed
the
erikd/ram
branch
3 times, most recently
from
September 4, 2026 18:03
6908f44 to
b7abdf4
Compare
koslambrou
approved these changes
Sep 4, 2026
koslambrou
enabled auto-merge
September 4, 2026 18:05
10 tasks
Test Failures |
The updated version uses the crypton/ram dependency in place of the crypton/memory dependency.
Unfortunately, this also requires a crypton >= 1.1 bound on cardano-crypto-wrapper. We cannot make the dependency on a wider range of crypton because earlier versions depend on memory and crypton >= 1.1 depends on ram. The only way to support both would be to add a cabal flag.
koslambrou
force-pushed
the
erikd/ram
branch
from
September 5, 2026 00:59
b7abdf4 to
fb72384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Will be using this as a SRP on a experimental branch of
cardano-node.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).cleret cabal run generate-cddl)hie.yamlupdated (usescripts/gen-hie.sh).