Skip to content

Adjust transaction serialization in BlockBody - #5985

Merged
Lucsanszky merged 2 commits into
masterfrom
ldan/adjust-bbody-tx-serialization
Sep 1, 2026
Merged

Adjust transaction serialization in BlockBody#5985
Lucsanszky merged 2 commits into
masterfrom
ldan/adjust-bbody-tx-serialization

Conversation

@Lucsanszky

@Lucsanszky Lucsanszky commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Resolves #5912

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use cleret cabal run generate-cddl)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky changed the title ldan/adjust bbody tx serialization Adjust transaction serialization in BlockBody Aug 6, 2026
@Lucsanszky
Lucsanszky force-pushed the ldan/adjust-bbody-tx-serialization branch from 3aece7d to 28e8f5e Compare August 25, 2026 23:52
@Lucsanszky
Lucsanszky marked this pull request as ready for review August 26, 2026 14:54
@Lucsanszky
Lucsanszky requested a review from a team as a code owner August 26, 2026 14:54
@Lucsanszky
Lucsanszky force-pushed the ldan/adjust-bbody-tx-serialization branch 3 times, most recently from b483928 to fae1945 Compare August 31, 2026 11:05

@lehins lehins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thank you!

@Lucsanszky
Lucsanszky force-pushed the ldan/adjust-bbody-tx-serialization branch from fae1945 to 99ea064 Compare September 1, 2026 18:44
@Lucsanszky
Lucsanszky enabled auto-merge September 1, 2026 18:54
@Lucsanszky
Lucsanszky force-pushed the ldan/adjust-bbody-tx-serialization branch from 99ea064 to 1aef046 Compare September 1, 2026 18:56
Each transaction in a Dijkstra block body is now serialized as
`[transaction_body, transaction_witness_set, auxiliary_data/ nil, bool]`
and the `invalid_transactions` field is removed from the block body.
The `is_valid` flag comes after all the fields that are supplied by the
transaction author, since it is set by the block producer. This also
leaves room for future block-producer-supplied fields.

Rename the `transaction` and `transaction_mempool` CDDL rules to
`block_transaction` and `mempool_transaction`.

Implements the serialization part of #5912
@Lucsanszky
Lucsanszky force-pushed the ldan/adjust-bbody-tx-serialization branch from 1aef046 to 8b42867 Compare September 1, 2026 19:17
@Lucsanszky
Lucsanszky merged commit bb3cd81 into master Sep 1, 2026
51 checks passed
@Lucsanszky
Lucsanszky deleted the ldan/adjust-bbody-tx-serialization branch September 1, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust transaction serialization in block body

2 participants