Skip to content

feat(button-group): add roving focus and move the group ARIA to the host #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkaraivanov merged 4 commits into from
Sep 17, 2026
+692 −90
Merged

feat(button-group): add roving focus and move the group ARIA to the host #2385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0852a42
feat(button-group): add roving focus and move the group ARIA to the host
rkaraivanov Sep 17, 2026
2f00c72
fix: address PR review comments
rkaraivanov Sep 17, 2026
525ec48
fix(button-group): return the author tab index when a button leaves a…
rkaraivanov Sep 17, 2026
fdde9a3
fix(button-group): keep a button's tab order once it leaves the group
rkaraivanov Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Added
- #### Button group
- The single selection modes now follow the ARIA radio group keyboard pattern. The group is a single tab stop, and the arrow keys move both focus and the selection, skipping the disabled buttons and wrapping at both ends. The `alignment` picks the axis: `horizontal` binds ArrowLeft and ArrowRight and follows the writing direction, `vertical` binds ArrowUp and ArrowDown. Before, every button was a separate tab stop and the arrow keys did nothing, which the `radiogroup` role does not allow. The `multiple` selection mode is unchanged, as each of its buttons stays a tab stop of its own.

### Changed
- #### Button group
- The `radiogroup` and `group` roles, and the disabled state, now sit on the `igc-button-group` element instead of an element inside its shadow root. Thus an `aria-label` or `aria-labelledby` that you set on the component names the group.

### Fixed
- #### Carousel
- Indicators now carry their `aria-label` as a content attribute in addition to `ElementInternals`, thus accessibility tools that do not read internals report the tab name.
Expand Down
Loading