fix(*): add theme link to prevent style flash - #1251
Closed
ChronosSF wants to merge 1 commit into
Closed
Conversation
Member
|
Closing in favor of #1253 where these changes are incorporated with other improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sample theming and first-paint flash
Material samples rendered with the bootstrap theme in builds. Rollup made a sample chunk the host for shared IgniteUI code, so loading any sample also ran that host's module body — injecting its
bootstrap.cssand callingdefineAllComponents()first. The library's one-shotgetTheme()latched onto the wrong theme before the sample's ownmaterial.cssexisted. Library code now goes tovendor/<package>chunks, so no sample's side effects run on another sample's page.Samples painted unstyled, then snapped into place. All sample CSS was injected at runtime by the lazily-imported sample chunk — 2.94 MB across a 7-deep waterfall, starting after
DOMContentLoaded. Stylesheets are now emitted into<head>at build time: Ignite UI themes as cacheable<link>s frompublic/ig-themes/, sample-local CSS inlined. Zero CSS is delivered via JS now. A time-bounded:not(:defined)guard covers the remaining custom-element upgrade window.Verified against the built output: button-group (material), grid, chart, Tailwind, and self-theming gallery samples all render correctly.
astro checkclean.Also adds
npm run build:preview.