chore: update dv packages to 20.1 - #1429
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates Ignite UI DV package versions referenced in Angular templates to the 20.1.x line.
- Bumps igniteui-angular-core, igniteui-angular-charts, igniteui-angular-gauges, and igniteui-angular-maps from ~20.0.0 to ~20.1.0 across templates.
- Updates the shared IGNITEUI_ANGULAR_PACKAGE constant to ~20.1.0.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/igx-templates/constants.ts | Updates the igniteui-angular base package constant to 20.1.0. |
| packages/igx-templates/igx-ts/radial-gauge/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts/linear-gauge/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts/bullet-graph/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts/category-chart/default/index.ts | Bumps core and charts packages to 20.1.0. |
| packages/igx-templates/igx-ts/financial-chart/default/index.ts | Bumps core and charts packages to 20.1.0. |
| packages/igx-templates/igx-ts/map/default/index.ts | Bumps core, charts, and maps packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/radial-gauge/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/linear-gauge/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/bullet-graph/default/index.ts | Bumps core and gauges packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/category-chart/default/index.ts | Bumps core and charts packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/financial-chart/default/index.ts | Bumps core and charts packages to 20.1.0. |
| packages/igx-templates/igx-ts-legacy/map/default/index.ts | Bumps core, charts, and maps packages to 20.1.0. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1 +1 @@ | |||
| export const IGNITEUI_ANGULAR_PACKAGE = "igniteui-angular@~20.0.0"; | |||
| export const IGNITEUI_ANGULAR_PACKAGE = "igniteui-angular@~20.1.0"; | |||
There was a problem hiding this comment.
[nitpick] Version strings for DV packages (core, charts, gauges, maps) are duplicated across many templates. Consider centralizing them in constants.ts to reduce future maintenance and version drift. For example:
export const IGNITEUI_ANGULAR_DV_VERSION = "~20.1.0";
export const IGNITEUI_ANGULAR_CORE_PACKAGE = igniteui-angular-core@${IGNITEUI_ANGULAR_DV_VERSION};
export const IGNITEUI_ANGULAR_CHARTS_PACKAGE = igniteui-angular-charts@${IGNITEUI_ANGULAR_DV_VERSION};
export const IGNITEUI_ANGULAR_GAUGES_PACKAGE = igniteui-angular-gauges@${IGNITEUI_ANGULAR_DV_VERSION};
export const IGNITEUI_ANGULAR_MAPS_PACKAGE = igniteui-angular-maps@${IGNITEUI_ANGULAR_DV_VERSION};
| export const IGNITEUI_ANGULAR_PACKAGE = "igniteui-angular@~20.1.0"; | |
| export const IGNITEUI_ANGULAR_DV_VERSION = "~20.1.0"; | |
| export const IGNITEUI_ANGULAR_PACKAGE = `igniteui-angular@${IGNITEUI_ANGULAR_DV_VERSION}`; | |
| export const IGNITEUI_ANGULAR_CORE_PACKAGE = `igniteui-angular-core@${IGNITEUI_ANGULAR_DV_VERSION}`; | |
| export const IGNITEUI_ANGULAR_CHARTS_PACKAGE = `igniteui-angular-charts@${IGNITEUI_ANGULAR_DV_VERSION}`; | |
| export const IGNITEUI_ANGULAR_GAUGES_PACKAGE = `igniteui-angular-gauges@${IGNITEUI_ANGULAR_DV_VERSION}`; | |
| export const IGNITEUI_ANGULAR_MAPS_PACKAGE = `igniteui-angular-maps@${IGNITEUI_ANGULAR_DV_VERSION}`; |
| this.name = "Radial Gauge"; | ||
| this.description = "IgxRadialGauge with different animations"; | ||
| this.packages = ["igniteui-angular-core@~20.0.0", "igniteui-angular-gauges@~20.0.0", IGNITEUI_ANGULAR_PACKAGE]; | ||
| this.packages = ["igniteui-angular-core@~20.1.0", "igniteui-angular-gauges@~20.1.0", IGNITEUI_ANGULAR_PACKAGE]; |
There was a problem hiding this comment.
[nitpick] If you introduce DV package constants in constants.ts, update this to use them to avoid repeating versioned strings. For example:
this.packages = [IGNITEUI_ANGULAR_CORE_PACKAGE, IGNITEUI_ANGULAR_GAUGES_PACKAGE, IGNITEUI_ANGULAR_PACKAGE];
Apply the latest changes to the DV packages: https://www.npmjs.com/package/igniteui-angular-core