fix: Fix Combo Change event ChangeType enum not being decoded correctly. - #368
Open
skrustev wants to merge 2 commits into
Open
fix: Fix Combo Change event ChangeType enum not being decoded correctly.#368skrustev wants to merge 2 commits into
skrustev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes deserialization of the Combo Change event detail so Detail.ChangeType correctly reflects the underlying web component payload (notably for deselection), and updates enum parsing to be case-insensitive.
Changes:
- Remap
IgbComboChangeEventArgsDetail.ChangeTypeevent JSON decoding fromchangeTypeto the correcttypekey. - Make
StringToEnum<T>parsing case-insensitive to correctly handle lowercase event payload values (e.g.,"deselection"). - Add unit tests validating
ChangeTypeis received for both selection and deselection events.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/IgniteUI.Blazor.Tests/ComboTests.cs | Adds unit tests that assert the Combo Change event detail includes the expected ComboChangeType values. |
| src/componentsBase/BaseRendererControl.cs | Updates enum parsing to be case-insensitive to match event payload casing. |
| src/components/Blazor/ComboChangeEventArgsDetail.cs | Fixes inbound event JSON key mapping for ChangeType from changeType to type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChangeTypeproperty to WC propertyType of Change (check all that apply):
Component(s) / Area(s) Affected:
Combo, event enums
How Has This Been Tested?
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #352