Skip to content

fix: Fix Combo Change event ChangeType enum not being decoded correctly. - #368

Open
skrustev wants to merge 2 commits into
masterfrom
skrastev/fix-changeType
Open

fix: Fix Combo Change event ChangeType enum not being decoded correctly.#368
skrustev wants to merge 2 commits into
masterfrom
skrastev/fix-changeType

Conversation

@skrustev

@skrustev skrustev commented Aug 25, 2026

Copy link
Copy Markdown
Member

Description

  • Fix wrong mapping for ChangeType property to WC property
  • Fix enums converting from string not being case insensitive.

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog

Component(s) / Area(s) Affected:

Combo, event enums

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Closes #352

@skrustev
skrustev requested review from damyanpetev and a lite review from Copilot August 25, 2026 16:30
@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification combo labels Aug 25, 2026
Comment thread src/components/Blazor/ComboChangeEventArgsDetail.cs Dismissed
@skrustev skrustev changed the title fix: Fix Combo Change event ChangeType enum not being received. fix: Fix Combo Change event ChangeType enum not being decoded correctly. Aug 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes deserialization of the Combo Change event detail so Detail.ChangeType correctly reflects the underlying web component payload (notably for deselection), and updates enum parsing to be case-insensitive.

Changes:

  • Remap IgbComboChangeEventArgsDetail.ChangeType event JSON decoding from changeType to the correct type key.
  • Make StringToEnum<T> parsing case-insensitive to correctly handle lowercase event payload values (e.g., "deselection").
  • Add unit tests validating ChangeType is received for both selection and deselection events.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/IgniteUI.Blazor.Tests/ComboTests.cs Adds unit tests that assert the Combo Change event detail includes the expected ComboChangeType values.
src/componentsBase/BaseRendererControl.cs Updates enum parsing to be case-insensitive to match event payload casing.
src/components/Blazor/ComboChangeEventArgsDetail.cs Fixes inbound event JSON key mapping for ChangeType from changeType to type.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/Blazor/ComboChangeEventArgsDetail.cs
@skrustev skrustev added the squash-merge Merge PR with "Squash and Merge" option label Aug 25, 2026
@dkamburov dkamburov self-assigned this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

combo squash-merge Merge PR with "Squash and Merge" option ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combo Change event ChangeType propety is not decoded correctly coming from WC

3 participants