fix(elements): Trigger additional change detection when method is invoked in elements - #17582
Open
mddragnev wants to merge 4 commits into
Open
fix(elements): Trigger additional change detection when method is invoked in elements#17582mddragnev wants to merge 4 commits into
mddragnev wants to merge 4 commits into
Conversation
mddragnev
added
❌ status: awaiting-test
mddragnev
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It introduces unconditional scheduler-triggered change detection after every method call (potentially redundant when Zone.js is present) and includes formatting issues likely to fail linting.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses missing Angular change detection in Ignite UI Angular Elements when Zone.js is removed, by scheduling additional change detection after invoking exposed component methods from the custom element layer.
Changes:
- Added a strategy-level
notifyChanges()hook to manually schedule change detection for Angular Elements. - Wrapped generated element method proxies to invoke
notifyChanges()after calling the underlying component method. - Added a unit test covering the “method invocation should trigger change detection” scenario (grid search/clear).
File summaries
| File | Description |
|---|---|
| projects/igniteui-angular-elements/src/app/custom-strategy.ts | Adds notifyChanges() and adjusts a local variable to const. |
| projects/igniteui-angular-elements/src/app/create-custom-element.ts | Updates method proxying to schedule change detection after method calls. |
| projects/igniteui-angular-elements/src/app/custom-strategy.spec.ts | Adds a unit test validating CD after invoking element methods. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
damyanpetev
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17581
Description
Needed because of zone.js removal
Motivation / Context
Without zone.js, native browser event listeners do not automatically trigger Angular change detection when component methods are invoked from event callbacks. Because UI state changes may occur across various public methods, change detection is defensively scheduled after every method call to ensure consistent state updates.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)