fix(*): add mustCoerceToInt to relevant props - master#17239
Open
IMinchev64 wants to merge 2 commits intomasterfrom
Open
fix(*): add mustCoerceToInt to relevant props - master#17239IMinchev64 wants to merge 2 commits intomasterfrom
IMinchev64 wants to merge 2 commits intomasterfrom
Conversation
IMinchev64
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the /* mustCoerceToInt */ metadata marker to several enum-typed interface properties so downstream metadata consumers (notably Blazor) resolve enum values as numbers rather than strings.
Changes:
- Annotate
IDimensionsChange.dimensionCollectionTypewith/* mustCoerceToInt */. - Annotate
IPinningConfig.columns/IPinningConfig.rowswith/* mustCoerceToInt */. - Annotate
PositionSettingsalignment properties with/* mustCoerceToInt */. - Annotate filtering expression tree enum properties (
operator,type) with/* mustCoerceToInt */.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/core/src/pivot-grid.interface.ts | Adds mustCoerceToInt marker to a pivot dimension-collection enum property for metadata generation. |
| projects/igniteui-angular/grids/core/src/common/grid.interface.ts | Adds mustCoerceToInt markers to pinning config enum properties. |
| projects/igniteui-angular/core/src/services/overlay/utilities.ts | Adds mustCoerceToInt markers to overlay position enum properties (alignment-related). |
| projects/igniteui-angular/core/src/data-operations/filtering-expressions-tree.ts | Adds mustCoerceToInt markers to filtering tree enum properties used in metadata. |
Comment on lines
+100
to
+109
| /* mustCoerceToInt */ | ||
| /** Direction in which the component should show */ | ||
| horizontalDirection?: HorizontalAlignment; | ||
| /* mustCoerceToInt */ | ||
| /** Direction in which the component should show */ | ||
| verticalDirection?: VerticalAlignment; | ||
| /* mustCoerceToInt */ | ||
| /** Target's starting point */ | ||
| horizontalStartPoint?: HorizontalAlignment; | ||
| /* mustCoerceToInt */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute is needed so the metadata descriptions which are used by Blazor can be updated which would resolve the enum values as numbers instead of strings.
Related to: https://infragistics.visualstudio.com/Indigo_Platform/_workitems/edit/34678
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)