Expression Language support#1654
Open
adamwojs wants to merge 20 commits intoHaehnchen:masterfrom
Open
Conversation
2aea320 to
2e248f5
Compare
Contributor
|
I had the same idea in mind a while ago. But since it's time consuming i didn't start working on it. Sounds good! 👍 Is it possible to (auto-)inject it inside DocTags and/or PHP8 attributes? |
Contributor
Author
|
Thank you for feedback @King2500!
Yes, I think it's possible. I will go through symfony documentation and try identify all possible spots before moving PR from draft to "Ready for review" state. |
efc97a8 to
16bbbdd
Compare
78b7cd8 to
3aa43aa
Compare
774e536 to
1347346
Compare
5cc0e30 to
6133ea9
Compare
98daa78 to
5464605
Compare
5464605 to
14afd15
Compare
44eba02 to
e5b4001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Expression Language component (https://symfony.com/doc/current/components/expression_language.html)
TODO
Auto inject expression language into:
\Symfony\Component\ExpressionLanguage\ExpressionLanguage::{evaluate,compile,parse}\Symfony\Component\ExpressionLanguage\Expression::__constructhttps://symfony.com/doc/current/reference/twig_reference.html#expressionMissing PsiLanguageInjectionHost impl. on TwigCompositeElement
Note for reviewers
Expression Language parser
fr.adrienbrault.idea.symfony2plugin.expressionLanguagepackageExpressionLanguage.bnfandExpressionLanguage.flexfiles as part of the plugin build process using https://github.com/JetBrains/gradle-grammar-kit-pluginLanguage Injections
fr.adrienbrault.idea.symfony2plugin.lang.ParameterLanguageInjectorin favour offr.adrienbrault.idea.symfony2plugin.lang.StringLiteralLanguageInjectorStringLiteralLanguageInjectorallows inject language into string literals used in various contexts: Attributes, Annotations, Constructor/Function/Method call argument, Variable assigment and also takes into account named arguments introduced in PHP 8YamlLanguageInjector/XmlLanguageInjectorLinks