Skip to content

update(packaging): declare plugin compatible with ProperDocs#431

Merged
Guts merged 1 commit intomainfrom
packaging/make-plugin-compatible-with-properdocs
Apr 9, 2026
Merged

update(packaging): declare plugin compatible with ProperDocs#431
Guts merged 1 commit intomainfrom
packaging/make-plugin-compatible-with-properdocs

Conversation

@Guts
Copy link
Copy Markdown
Owner

@Guts Guts commented Apr 9, 2026

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file packaging labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.74%. Comparing base (ce29ffc) to head (1a9e0da).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          11       11           
  Lines         769      769           
  Branches      129      129           
=======================================
  Hits          644      644           
  Misses         82       82           
  Partials       43       43           
Flag Coverage Δ
unittests 83.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Guts Guts force-pushed the packaging/make-plugin-compatible-with-properdocs branch from f4f13e7 to 1a9e0da Compare April 9, 2026 17:17
@Guts Guts enabled auto-merge April 9, 2026 17:17
@Guts Guts self-assigned this Apr 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@Guts Guts merged commit d8c89e2 into main Apr 9, 2026
13 checks passed
@Guts Guts deleted the packaging/make-plugin-compatible-with-properdocs branch April 9, 2026 17:18
@miketheman
Copy link
Copy Markdown
Contributor

Hey @Guts ! Curious about this one - since now both mkdocs and properdocs get installed as a result.

Thinking about it, would it make sense to even drop both as dependencies, since I'm guessing that folks installing this plugin would want one or the other, but probably not both?

@Guts
Copy link
Copy Markdown
Owner Author

Guts commented Apr 17, 2026

@miketheman You're right but for now, it's the best solution I've found. It's a temporary solution, to let the ecosystem drama die down.

@miketheman
Copy link
Copy Markdown
Contributor

@Guts I hear you completely. Not relying on either is a better overall solution in my head, but it's your choice of course.

The inclusion of both has prompted me to pin to the release prior to not get both installed and potentially have more drama.

@Guts
Copy link
Copy Markdown
Owner Author

Guts commented Apr 17, 2026

As solution, you can do this :

  1. fork this repo
  2. create a branch like only-one-ssg
  3. Remove the line you don't want in the pyproject.toml
  4. On your website repo, tell pip to install through VCS pointing to your repo/branch

@miketheman
Copy link
Copy Markdown
Contributor

Oh, it's fine - I wasn't asking for a complete solution, but thanks! I'm happy to sit and wait things out for now.

@Guts
Copy link
Copy Markdown
Owner Author

Guts commented Apr 17, 2026

Let's see what will happen next. I hope things will calm down, although there will inevitably be some occasional flare-ups.

In the meanwhile, I'll continue to maintain and improve this plugin on my spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants