Drop EOL Python 3.8-3.9#79
Merged
anticomputer merged 2 commits intoGitHubSecurityLab:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s declared Python support to drop EOL versions (3.8/3.9) and modernizes type hints accordingly, aligning the packaging metadata and docs with Python ≥ 3.10.
Changes:
- Bump
requires-pythonto>=3.10and remove Python 3.8/3.9 classifiers. - Update SQLAlchemy model annotations from
Optional[T]toT | None. - Update README requirements to reflect Python ≥ 3.10.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/seclab_taskflows/mcp_servers/ghsa_models.py |
Replace Optional[...] annotations with `... |
src/seclab_taskflows/mcp_servers/codeql_python/codeql_sqlite_models.py |
Replace Optional[...] with `... |
src/seclab_taskflows/mcp_servers/alert_results_models.py |
Replace Optional[...] with `... |
pyproject.toml |
Raise minimum supported Python to 3.10 and remove 3.8/3.9 classifiers. |
README.md |
Document Python ≥ 3.10 requirement. |
Comments suppressed due to low confidence (1)
src/seclab_taskflows/mcp_servers/alert_results_models.py:30
relationship("AlertFlowGraph", cascade="all, delete")is called without assigning it to a mapped attribute, so it has no effect (the relationship/cascade won’t be configured on the model). Either assign it to a class attribute (with an appropriateMapped[...]type) or remove this line to avoid giving a false impression that ORM-level cascading is enabled.
created: Mapped[str | None]
valid: Mapped[bool] = mapped_column(nullable=False, default=True)
completed: Mapped[bool] = mapped_column(nullable=False, default=False)
relationship("AlertFlowGraph", cascade="all, delete")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anticomputer
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://devguide.python.org/versions/