Skip to content

Drop EOL Python 3.8-3.9#79

Merged
anticomputer merged 2 commits intoGitHubSecurityLab:mainfrom
hugovk:main
Apr 22, 2026
Merged

Drop EOL Python 3.8-3.9#79
anticomputer merged 2 commits intoGitHubSecurityLab:mainfrom
hugovk:main

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s declared Python support to drop EOL versions (3.8/3.9) and modernizes type hints accordingly, aligning the packaging metadata and docs with Python ≥ 3.10.

Changes:

  • Bump requires-python to >=3.10 and remove Python 3.8/3.9 classifiers.
  • Update SQLAlchemy model annotations from Optional[T] to T | None.
  • Update README requirements to reflect Python ≥ 3.10.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/seclab_taskflows/mcp_servers/ghsa_models.py Replace Optional[...] annotations with `...
src/seclab_taskflows/mcp_servers/codeql_python/codeql_sqlite_models.py Replace Optional[...] with `...
src/seclab_taskflows/mcp_servers/alert_results_models.py Replace Optional[...] with `...
pyproject.toml Raise minimum supported Python to 3.10 and remove 3.8/3.9 classifiers.
README.md Document Python ≥ 3.10 requirement.
Comments suppressed due to low confidence (1)

src/seclab_taskflows/mcp_servers/alert_results_models.py:30

  • relationship("AlertFlowGraph", cascade="all, delete") is called without assigning it to a mapped attribute, so it has no effect (the relationship/cascade won’t be configured on the model). Either assign it to a class attribute (with an appropriate Mapped[...] type) or remove this line to avoid giving a false impression that ORM-level cascading is enabled.
    created: Mapped[str | None]
    valid: Mapped[bool] = mapped_column(nullable=False, default=True)
    completed: Mapped[bool] = mapped_column(nullable=False, default=False)

    relationship("AlertFlowGraph", cascade="all, delete")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anticomputer anticomputer merged commit d1ffa8c into GitHubSecurityLab:main Apr 22, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants