General updates#12
Merged
GeekMasher merged 13 commits intomainfrom Jun 12, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and refactoring to the Bicep framework's CodeQL library. The changes primarily focus on standardizing resource property handling, improving type specificity, and adding new abstractions for better resource modeling. Below is a summary of the most important changes grouped by theme:
Standardization of Resource Properties
ResourcePropertiesclass inql/lib/codeql/bicep/frameworks/Microsoft/General.qllto serve as a base for all resource-specific property classes, replacing the genericObjecttype across multiple modules.Propertiesclasses across modules (Cache.qll,Compute.qll,Containers.qll,Databases.qll,ManagedContainers.qll,Network.qll,Storage.qll) to inherit fromResourcePropertiesinstead ofObject. [1] [2] [3] [4] [5] [6]Enhanced Resource Modeling
OsProfile,SshConfig, andSshPublicKeyinCompute.qll, providing more granular access to properties likeosType,ssh, andkeyData. [1] [2]ManagedContainers.qll, including detailed classes forAgentPoolProfiles,ApiServerAccessProfile, and various addon profiles.Improved Type Specificity
ExprwithIdentsinExpr.qllandOsProfileinCompute.qll. [1] [2]StorageAccountPropertiesandDisksPropertiesinStorage.qll.New Resource Support
DiskPools,BlobServiceContainers, and their associated properties inStorage.qll. These additions improve the framework's ability to analyze storage-related resources.Test Updates
ql/test/library-tests/frameworks/cache/Cache.expectedto reflect changes in theCachePropertiesstructure.