Allow admin to force team type change - #8471
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8471 +/- ##
==========================================
+ Coverage 76.77% 76.88% +0.10%
==========================================
Files 460 460
Lines 24703 24745 +42
Branches 6573 6598 +25
==========================================
+ Hits 18966 19024 +58
+ Misses 5737 5721 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hardillb
left a comment
There was a problem hiding this comment.
Logically looks good, I don't have enough local billing stuff setup to test the all the UI tweaks (should really find time to set it all up again)
|
The new
The same undercount also flows into Might be worth having the gate read |
Follow up to #8456
This allows an admin to change team type of an manual billing team even if the team usage exceeds the new team type usage limits. A warning is shown to the admin making the change in this scenario - telling them to apply the necessary limit overrides after making the team type change.
The second commit fixes the handling of a
0device limit in the frontend. That was interpreted to mean 'unlimited' - whereas the backend uses-1to mean unlimited. With the new Hub plan, a limit of0is valid but wasn't being honoured in the UI.With this fix it now shows the team limit banner on the Remote instance page, and disables the 'add instance' button on the team home page if the limit has been reached.