Skip to content

Add the onboarding surface variant to the expert components - #8439

Open
cstns wants to merge 3 commits into
mainfrom
8381-expert-surface-variant
Open

Add the onboarding surface variant to the expert components#8439
cstns wants to merge 3 commits into
mainfrom
8381-expert-surface-variant

Conversation

@cstns

@cstns cstns commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Part of #8381 / #8380, stacked on #8436. First of two PRs for the onboarding surface; the page that activates all of this comes in the next one.

This teaches the shared expert chat components an expert-surface variant, injected with a 'drawer' default so nothing changes anywhere until a surface provides 'onboarding'. Under that variant:

  • ExpertMessages renders through a new pure buildCollapsedTranscript helper: past question turns (the AI questions message plus the composed human reply) fold into folded-turn entries, the collapsing transcript treatment from the mockups on Build the onboarding UI #8380. The drawer path maps messages through unchanged.
  • A new CollapsedQuestionTurn renders the fold: one quiet line per question with the picks as pill chips (one chip per pick for multi selects), a Skipped marker for unanswered stale turns, expand/collapse to the original messages, and chip clicks loading the "question answer" line into the composer, since correcting a sent answer means sending a new message.
  • Expert.vue hides the info banner and skips the canned welcome message (the Expert opens the onboarding conversation itself, Open the onboarding conversation without waiting for the user #8369).
  • ExpertChatInput hides Start over, Plan mode and the settings cog, and reads "Or just tell me in your own words".

Everything is inert without a provider, so the reviewable claim here is that the drawer rendering is byte identical. Covered by 12 unit tests over the fold helper and the folded turn component.

@cstns cstns self-assigned this Sep 7, 2026
@cstns cstns changed the title [8381] Add the onboarding surface variant to the expert components Add the onboarding surface variant to the expert components Sep 7, 2026
@cstns
cstns marked this pull request as ready for review September 7, 2026 14:39
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.88%. Comparing base (b95185a) to head (302223c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8439   +/-   ##
=======================================
  Coverage   76.88%   76.88%           
=======================================
  Files         460      460           
  Lines       24741    24741           
  Branches     6596     6596           
=======================================
  Hits        19022    19022           
  Misses       5719     5719           
Flag Coverage Δ
backend 76.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns
cstns force-pushed the 8381-expert-surface-variant branch from 79e389a to d3291e5 Compare September 9, 2026 11:50
@cstns
cstns requested a review from andypalmi September 9, 2026 14:11
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from d3291e5 to 75b8a06 Compare September 9, 2026 14:15
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from 75b8a06 to a2b69c9 Compare September 10, 2026 09:02
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from 2d30728 to f59c4db Compare September 10, 2026 11:57
Base automatically changed from 8368-default-workspace-endpoint to main September 10, 2026 12:21
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from f59c4db to b73cb4b Compare September 10, 2026 12:21
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from b73cb4b to b96a046 Compare September 10, 2026 12:26
It had invented a composables folder inside the component tree. Composables
live under frontend/src/composables, mirroring the path of whatever they are
namespaced to, the way InstanceFormHelper sits under
composables/Components/multi-step-forms/instance.

The spec moves to test/unit/frontend/composables, flat, matching how the
existing composable specs sit there regardless of source subdirectory.

Also drops the explanatory comments on the onboarding branches in
ExpertChatInput and ExpertMessages.
@cstns
cstns force-pushed the 8381-expert-surface-variant branch from b96a046 to 302223c Compare September 10, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant