Skip to content

Return crafting remainders when condensing - #6625

Open
Touchie771 wants to merge 2 commits into
EssentialsX:2.xfrom
Touchie771:honey-condense-fix
Open

Return crafting remainders when condensing#6625
Touchie771 wants to merge 2 commits into
EssentialsX:2.xfrom
Touchie771:honey-condense-fix

Conversation

@Touchie771

Copy link
Copy Markdown
Contributor

Information

This PR fixes #3760

Details

Proposed fix:

After /condense pays the user the block, it now checks if the crafting remainder is a glass bottle and if yes, it also pays the empty bottles back, the number of bottles is equal to the number of input honey bottles, so the amount is simply input.getAmount();

Environments tested:

OS: Linux (Ubuntu 24.04)

Java version: 21

  • Most recent Paper version (XX.YY.Z, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

@mdcfe

mdcfe commented Sep 13, 2026

Copy link
Copy Markdown
Member

No strong objections to this change, but it seems weird to special-case this to glass bottles only when other recipes could have a remainder?

@Touchie771

Copy link
Copy Markdown
Contributor Author

Good point, I switched the remainder check so now it just checks if the remainder is null or not instead of checking specifically for glass bottles.

@Touchie771 Touchie771 changed the title Return glass bottles when condensing honey bottles Return crafting remainders when condensing Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Condense on honey bottles doesn't let you keep the glass bottles

2 participants