Return crafting remainders when condensing - #6625
Open
Touchie771 wants to merge 2 commits into
Open
Conversation
Member
|
No strong objections to this change, but it seems weird to special-case this to glass bottles only when other recipes could have a remainder? |
Contributor
Author
|
Good point, I switched the remainder check so now it just checks if the remainder is null or not instead of checking specifically for glass bottles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #3760
Details
Proposed fix:
After /condense pays the user the block, it now checks if the crafting remainder is a glass bottle and if yes, it also pays the empty bottles back, the number of bottles is equal to the number of input honey bottles, so the amount is simply
input.getAmount();Environments tested:
OS: Linux (Ubuntu 24.04)
Java version: 21