feat - Support 'Ignore Case' in TryParseFast#128
Open
iiiixxl wants to merge 1 commit intoEngRajabi:masterfrom
Open
feat - Support 'Ignore Case' in TryParseFast#128iiiixxl wants to merge 1 commit intoEngRajabi:masterfrom
iiiixxl wants to merge 1 commit intoEngRajabi:masterfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
test/Console.Test.Benchmark/Program.cs:168
- [nitpick] The method name 'Parse_CaseInsensitive_Ordinal' suggests a case-insensitive parse, but using StringComparison.Ordinal is case-sensitive. Consider renaming the method or adjusting the comparison parameter for clarity.
UserTypeEnumExtensions.TryParseFast("men", out _, StringComparison.Ordinal);
Supernova.Enum.Generators/EnumSourceGenerator.cs:452
- [nitpick] The parameter name 'states' is unclear in this context; consider renaming it to 'input' or 'value' to better reflect its purpose.
public static bool {SourceGeneratorHelper.ExtensionMethodNameTryParse}(string states, out {symbol.FullName()} result,StringComparison comparisonType)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #121, the source generator code was modified to support the use of string.Compare as expected by the user.
Generator result:

Source code:

Unit test:

BenchMark result:
