Skip to content

Support absolute filesystem paths in setUploadDir() #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lacatoire wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Support absolute filesystem paths in setUploadDir() #7578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ba5744
fix #7459 support absolute filesystem paths in setUploadDir()
lacatoire Apr 22, 2026
9591e70
fix doc/fields.rst RST indentation for doc-linter
lacatoire Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/fields.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,8 +1127,8 @@ the full address is only visible on the detail and edit pages::

[$local, $domain] = explode('@', $email, 2);
$field->setFormattedValue(substr($local, 0, 1).'***@'.$domain);
}
}
}
}

.. tip::

Expand Down
9 changes: 5 additions & 4 deletions src/Field/Configurator/FileConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,12 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
// Disable download_path for Flysystem (URLs are built via flysystem_url_prefix)
$field->setFormTypeOption('download_path', null);
} else {
$relativeUploadDir = u($relativeUploadDir)->trimStart(\DIRECTORY_SEPARATOR)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
$isStreamWrapper = filter_var($relativeUploadDir, \FILTER_VALIDATE_URL);
if (false !== $isStreamWrapper) {
$absoluteUploadDir = $relativeUploadDir;
$isStreamWrapper = false !== filter_var($relativeUploadDir, \FILTER_VALIDATE_URL);
$isAbsolutePath = str_starts_with($relativeUploadDir, \DIRECTORY_SEPARATOR);
if ($isStreamWrapper || $isAbsolutePath) {
$absoluteUploadDir = u($relativeUploadDir)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
} else {
$relativeUploadDir = u($relativeUploadDir)->trimStart(\DIRECTORY_SEPARATOR)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
$absoluteUploadDir = u($relativeUploadDir)->ensureStart($this->projectDir.\DIRECTORY_SEPARATOR)->toString();
}
$field->setFormTypeOption('upload_dir', $absoluteUploadDir);
Expand Down
9 changes: 5 additions & 4 deletions src/Field/Configurator/ImageConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,12 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
// Disable download_path for Flysystem (URLs are built via flysystem_url_prefix)
$field->setFormTypeOption('download_path', null);
} else {
$relativeUploadDir = u($relativeUploadDir)->trimStart(\DIRECTORY_SEPARATOR)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
$isStreamWrapper = filter_var($relativeUploadDir, \FILTER_VALIDATE_URL);
if (false !== $isStreamWrapper) {
$absoluteUploadDir = $relativeUploadDir;
$isStreamWrapper = false !== filter_var($relativeUploadDir, \FILTER_VALIDATE_URL);
$isAbsolutePath = str_starts_with($relativeUploadDir, \DIRECTORY_SEPARATOR);
if ($isStreamWrapper || $isAbsolutePath) {
$absoluteUploadDir = u($relativeUploadDir)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
} else {
$relativeUploadDir = u($relativeUploadDir)->trimStart(\DIRECTORY_SEPARATOR)->ensureEnd(\DIRECTORY_SEPARATOR)->toString();
$absoluteUploadDir = u($relativeUploadDir)->ensureStart($this->projectDir.\DIRECTORY_SEPARATOR)->toString();
}
$field->setFormTypeOption('upload_dir', $absoluteUploadDir);
Expand Down
3 changes: 2 additions & 1 deletion src/Field/FileField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ public function setBasePath(string $path): self
}

/**
* Relative to project's root directory (e.g. use 'public/uploads/' for `<your-project-dir>/public/uploads/`)
* Relative paths are resolved from the project's root directory (e.g. 'public/uploads/' for `<your-project-dir>/public/uploads/`).
* Absolute filesystem paths are also supported (e.g. '/mnt/data/uploads/'), and so are stream wrappers (e.g. 's3://bucket/path/').
* Default upload dir: `<your-project-dir>/public/uploads/files/`.
*/
public function setUploadDir(string $uploadDirPath): self
Expand Down
3 changes: 2 additions & 1 deletion src/Field/ImageField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public function setBasePath(string $path): self
}

/**
* Relative to project's root directory (e.g. use 'public/uploads/' for `<your-project-dir>/public/uploads/`)
* Relative paths are resolved from the project's root directory (e.g. 'public/uploads/' for `<your-project-dir>/public/uploads/`).
* Absolute filesystem paths are also supported (e.g. '/mnt/data/uploads/'), and so are stream wrappers (e.g. 's3://bucket/path/').
* Default upload dir: `<your-project-dir>/public/uploads/images/`.
*/
public function setUploadDir(string $uploadDirPath): self
Expand Down
Loading