Prevent ImageField from overwriting existing files#7577
Open
lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
Open
Prevent ImageField from overwriting existing files#7577lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
upload_validatecallable inFileUploadTypechecksfile_exists()to avoid collisions, but it only received the file basename, so the check was always false and existing files were silently overwritten.StringToFileTransformernow passes the fullupload_dir + filenamepath toupload_validateand strips the prefix from the returned value, restoring the intended collision detection for both local and Flysystem storage.Fixes #7525