Apply DefaultColumns to ChoiceField regardless of widget type#7575
Open
lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
Open
Apply DefaultColumns to ChoiceField regardless of widget type#7575lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
lacatoire wants to merge 4 commits intoEasyCorp:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ChoiceField uses the native
<select>widget (viarenderAsNativeWidget(true)), the default columns were never set because the call tosetDefaultColumns()was nested inside the autocomplete branch, leaving the field with an overly wide layout.Moving the default columns assignment outside that conditional restores the expected column sizing for all widget types, while preserving the existing values for the autocomplete widget.
Fixes #7550