Allow buttons to grow and wrap with long or multi-line content#7563
Open
lacatoire wants to merge 1 commit intoEasyCorp:4.xfrom
Open
Allow buttons to grow and wrap with long or multi-line content#7563lacatoire wants to merge 1 commit intoEasyCorp:4.xfrom
lacatoire wants to merge 1 commit intoEasyCorp:4.xfrom
Conversation
bf0ba2b to
ae1d031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7303.
Buttons used a fixed
block-sizeandmin-inline-size: max-content, which clipped multi-line or long labels and broke the.text-wraputility. Switching tomin-block-sizelets buttons grow vertically while preserving the default height for single-line content, and removingmin-inline-size: max-contentlets.text-wrapactually wrap the label inside tight containers.Three CSS lines changed in
assets/css/easyadmin-theme/buttons.css:.btn:block-size->min-block-size, dropmin-inline-size: max-content.btn-lg:block-size->min-block-sizeRegression checks performed locally with Chromium:
<br>) now fit inside the button instead of being clipped..text-wrapnow wraps the label and grows the button vertically, as intended.