Fix-indirect-(2nd-level)-teile-lookup-in-solutionQuery-for-DQL-task-79#6
Open
max-schmitz wants to merge 1 commit intoEILD-nrw:mainfrom
Conversation
…licit JOINs In the old query the indirect-filtering-part contained the two conditions 'unter.uteil = ober.oteil AND unter.uteil = 3' which effectively required 'ober.oteil = 3', so it only checks if teil 3 is child of teil 3 but not if there are teile that use teil 3 indirectly at the second level. This change now truly returns indirectly used teile at the second level, introduces distinct aliases (s0, s1), that make the hierarchy unambiguous and uses ANSI-style explicit joins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix second-level part filtering and refactor solutionQuery to use explicit JOINs
In the old query the indirect-filtering-part contained the two conditions 'unter.uteil = ober.oteil AND unter.uteil = 3'
which effectively required 'ober.oteil = 3', so it only checks if teil 3 is child of teil 3 but not if there are teile that use teil 3 indirectly at the second level.
This change now truly returns indirectly used teile at the second level, introduces distinct aliases (s0, s1), that make the hierarchy unambiguous and uses ANSI-style explicit joins.