Fix solution errors and add test to validate solutions#4
Open
evrys wants to merge 3 commits intoEILD-nrw:mainfrom
Open
Fix solution errors and add test to validate solutions#4evrys wants to merge 3 commits intoEILD-nrw:mainfrom
evrys wants to merge 3 commits intoEILD-nrw:mainfrom
Conversation
Currently, 40/351 of the provided solutions to tasks error out, so the user can't validate their answer for these tasks. This test helps find which solutions need to be fixed.
Open
|
Hey Evan, I am preparing for the same exam and I found a mistake that is not mentioned in your pull request. sql-trainer/src/Tasks/DDLTasks.ts Line 245 in e18dbce should be: "CREATE VIEW v_inspektion AS SELECT am, fahrzeug_id FROM Inspektionen WHERE firma = 'VeServ';",Thank you :)) |
Author
|
Added to the PR, thanks! Hopefully someone gets time to maintain this project since it's in active use by universities,, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hallo Alexander!
My friend is a CS student at Hochschule Bonn-Rhein-Sieg, and I've been helping him study for his databases exam using the sql-trainer. However, we've found that some of the tasks can't be answered, often because the provided solution uses invalid SQLite syntax.
This PR adds a jest test which validates the
solutionQueryfor every task, so it's easy to find which ones are broken. The test structure follows the recommendations for testing given by create-react-app. Tests can be run withnpm run testI've also gone through and fixed 39 queries which were caught by the test. There was however one task (DML 27) where the solutionQuery uses a non-standard Oracle SQL syntax
CONNECT BY PRIORto find all the descendants of a tree structure. I couldn't figure out how to do this in SQLite without an unresonably complex query, so I commented out the task.Also fixes #2
Thanks for your cool project!