Reset test settings before clearing the data-directory override - #5368
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoSep 10, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
September 10, 2026 19:23
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes correctly preserve test isolation without introducing unresolved issues.
Pull request overview
Reorders test cleanup so settings are reset while temporary directory overrides remain active, preventing accidental interaction with real user settings.
Changes:
- Moves
Settings.ResetSettings()before clearing test overrides in two test fixtures.
File summaries
| File | Description |
|---|---|
OperationCallArgsWiringTests.cs |
Corrects cleanup ordering. |
ShimStandardInputTests.cs |
Corrects cleanup ordering. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "4c28def0-ad4d-11f1-8903-9dbbbb8c6581",
"headSha": "8166918ff4b3243dcdfcfc3961e3099e81af435c",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/tests-wiping-real-settings
branch
September 10, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor refactor to the test cleanup logic in the
Disposemethods of two test classes. The main change is reordering the call toSettings.ResetSettings()to ensure it occurs before resetting other test overrides, which may improve test isolation and reliability.Test cleanup improvements:
src/UniGetUI.PackageEngine.Tests/OperationCallArgsWiringTests.cs: Moved the call toSettings.ResetSettings()to the start of theDisposemethod for more predictable test state reset.src/UniGetUI.PackageEngine.Tests/ShimStandardInputTests.cs: Likewise, reorderedSettings.ResetSettings()to be the first statement in theDisposemethod.