Skip to content

Reset test settings before clearing the data-directory override - #5368

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/tests-wiping-real-settings
Sep 10, 2026
Merged

Reset test settings before clearing the data-directory override#5368
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/tests-wiping-real-settings

Conversation

@GabrielDuf

Copy link
Copy Markdown
Contributor

This pull request makes a minor refactor to the test cleanup logic in the Dispose methods of two test classes. The main change is reordering the call to Settings.ResetSettings() to ensure it occurs before resetting other test overrides, which may improve test isolation and reliability.

Test cleanup improvements:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes correctly preserve test isolation without introducing unresolved issues.

Pull request overview

Reorders test cleanup so settings are reset while temporary directory overrides remain active, preventing accidental interaction with real user settings.

Changes:

  • Moves Settings.ResetSettings() before clearing test overrides in two test fixtures.
File summaries
File Description
OperationCallArgsWiringTests.cs Corrects cleanup ordering.
ShimStandardInputTests.cs Corrects cleanup ordering.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "4c28def0-ad4d-11f1-8903-9dbbbb8c6581",
	"headSha": "8166918ff4b3243dcdfcfc3961e3099e81af435c",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 1f759e3 into main Sep 10, 2026
12 of 14 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the fix/tests-wiping-real-settings branch September 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants