Limit how many local backups are kept - #5318
Merged
Gabriel Dufresne (GabrielDuf) merged 3 commits intoAug 24, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
August 24, 2026 13:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable retention for timestamped local backups across backup creation, IPC, settings UI, localization, and tests.
Changes:
- Centralizes backup naming, directory resolution, and retention.
- Adds retention settings and UI controls.
- Adds IPC fields and retention tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/UniGetUI.Interface.IpcApi/IpcBackupApi.cs |
Exposes and applies retention through IPC. |
src/UniGetUI.Core.Tools/LocalBackupManager.cs |
Implements naming and retention logic. |
src/UniGetUI.Core.Tools.Tests/LocalBackupManagerTests.cs |
Tests retention and timestamp handling. |
src/UniGetUI.Core.Settings/SettingsEngine_Names.cs |
Defines retention settings keys. |
src/UniGetUI.Avalonia/Views/Pages/SettingsPages/Backup.axaml.cs |
Manages retention control layout. |
src/UniGetUI.Avalonia/Views/Pages/SettingsPages/Backup.axaml |
Adds retention controls. |
src/UniGetUI.Avalonia/ViewModels/Pages/SettingsPages/BackupViewModel.cs |
Connects settings and backup logic. |
src/UniGetUI.Avalonia/Infrastructure/SettingsSearchIndex.cs |
Indexes new settings. |
src/Languages/lang_en.json |
Adds English localization keys. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
August 24, 2026 14:23
View session
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 24, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
feature/5279-local-backup-retention-limit
branch
August 24, 2026 15:34
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive backup retention feature for local backups, allowing users to limit the number of backup files kept and to manage backup file naming and retention more flexibly. The changes affect both the backend logic and the user interface, and include robust tests to ensure correct behavior.
Backup retention and file management enhancements:
MaxLocalBackupCount,MaxLocalBackupCountCustom) and their resolution in the settings engine.User interface improvements:
Testing and reliability:
LocalBackupManagerTests.cs) to verify backup retention logic, file naming, settings integration, and edge cases such as unrelated files and non-Gregorian calendars.These changes provide users with greater control over backup file management, improve clarity in the UI, and ensure robust, predictable behavior for backup retention.