fix(store.c): improve root path integrity check with range-based validation#311
Open
noctrex wants to merge 1 commit intoDeusData:mainfrom
Open
fix(store.c): improve root path integrity check with range-based validation#311noctrex wants to merge 1 commit intoDeusData:mainfrom
noctrex wants to merge 1 commit intoDeusData:mainfrom
Conversation
…dation Replace the fragile NOT IN list of individual characters with a range-based BETWEEN 'A' AND 'Z' check for validating project root paths. The previous query only excluded letters A–H, leaving paths starting with I–Z silently invalid. In Windows, all the alphabet can be used. A Windows drive starting with letters I-Z breaks the saving of the database.
DeusData
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
NOT INlist of individual characters with a range-basedBETWEEN 'A' AND 'Z'check for validating project root paths.The previous query only excluded letters A–H, leaving paths starting with I–Z silently invalid.
In Windows, all the alphabet can be used.
A Windows drive starting with letters I-Z breaks the saving of the database.