Skip to content

Upd. Integrations. Nextend Social Login: set altsession mode if Google auth provided and set up. - #841

Merged
alexandergull merged 1 commit into
devfrom
nsl_plugin_set_altsessions.ag
Jul 28, 2026
Merged

Upd. Integrations. Nextend Social Login: set altsession mode if Google auth provided and set up.#841
alexandergull merged 1 commit into
devfrom
nsl_plugin_set_altsessions.ag

Conversation

@alexandergull

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Nextend Social Login integration to require alternative session handling when Google OAuth is configured, and adds unit tests around the integration helper behavior.

Changes:

  • Add NextendSocialLogin::isOAuthProviderEnabled() to detect whether an OAuth provider is configured (via saved option).
  • Extend State::isAltSessionsRequired() to require alt sessions when Nextend Social Login is active and Google OAuth is set up.
  • Add PHPUnit coverage for NextendSocialLogin data extraction, blocking behavior, and provider-enabled detection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/Antispam/Integrations/TestNextendSocialLogin.php Adds unit tests for the Nextend Social Login integration behavior and option-based provider detection.
lib/Cleantalk/ApbctWP/State.php Adds an alt-sessions trigger for Nextend Social Login when Google OAuth is configured.
lib/Cleantalk/Antispam/Integrations/NextendSocialLogin.php Adds provider-enabled detection helper and makes getDataForChecking() explicitly return null when unsupported.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/Cleantalk/Antispam/Integrations/NextendSocialLogin.php
Comment thread lib/Cleantalk/ApbctWP/State.php
@alexandergull
alexandergull force-pushed the nsl_plugin_set_altsessions.ag branch from 159c2ba to 71a6986 Compare July 27, 2026 19:42
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.63%. Comparing base (7d4b7a6) to head (71a6986).

Files with missing lines Patch % Lines
...ntalk/Antispam/Integrations/NextendSocialLogin.php 77.77% 2 Missing ⚠️
lib/Cleantalk/ApbctWP/State.php 33.33% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #841      +/-   ##
============================================
+ Coverage     27.58%   27.63%   +0.05%     
- Complexity     6052     6059       +7     
============================================
  Files           282      282              
  Lines         25180    25189       +9     
============================================
+ Hits           6946     6962      +16     
+ Misses        18234    18227       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexandergull
alexandergull merged commit 24a7c39 into dev Jul 28, 2026
9 of 10 checks passed
@alexandergull
alexandergull deleted the nsl_plugin_set_altsessions.ag branch July 28, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants