Udp.Code.Incorrect logs - #729
Open
alexander-b-clean wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new country-preference helper can throw a PHP 8+ TypeError when IP info returns an empty string and the log has a non-empty country code.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adjusts firewall log presentation and schema to correctly represent the “skipped network” pass status and to prefer the country code stored in firewall logs when it conflicts with the IP info service’s country resolution.
Changes:
- Prefer the firewall log’s stored
country_codeover the IP-info-derived country when they disagree. - Add UI/status formatting for
PASS_AS_SKIPPED_NETWORKin firewall log rows. - Extend the
firewall_logs.statusENUM schema to includePASS_AS_SKIPPED_NETWORK.
File summaries
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/Firewall/View.php | Adjusts React data rows (country selection + status label) for firewall log display. |
| lib/CleantalkSP/SpbctWP/DB/SQLSchema.php | Updates DB schema enum to support the new/previously-used status value. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+139
to
+141
| if ( isset($country['country_code']) && $country['country_code'] === $country_code ) { | ||
| return $country; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/41240