Skip to content

Udp.Code.Malware scanning new description - #716

Merged
alexander-b-clean merged 8 commits into
devfrom
malware-scanning-text.ab
Aug 26, 2026
Merged

Udp.Code.Malware scanning new description#716
alexander-b-clean merged 8 commits into
devfrom
malware-scanning-text.ab

Conversation

@alexander-b-clean

Copy link
Copy Markdown
Contributor

@alexander-b-clean
alexander-b-clean requested a lite review from Copilot August 18, 2026 09:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

inc/spbc-settings.php:4704

  • The new external link opens in a new tab but is missing rel="noopener noreferrer" (tabnabbing protection). Also, other “Learn more” links in this same function are hidden when white-label mode is enabled (see $tc_learn_more_link / $two_fa_learn_more_link), but this new CleanTalk help link is always shown; consider gating it the same way to avoid leaking CleanTalk branding in WL mode.
            'desc'  => __('These rules will exclude files or directories (and all subdirectories) matching the specified path. Any type of directory separator is acceptable. Example: wp-content/themes/yourtheme/skipthisdir or wp-content/uploads/file.txt', 'security-malware-firewall')
                . '<p><a class="spbc_long_desc__link" href="https://cleantalk.org/help/exclude-files-and-folders-from-malware-scanning" target="_blank">'
                . __('Learn more', 'security-malware-firewall')
                . '</a></p>',

Comment thread inc/spbc-settings.php Outdated
@Glomberg

Copy link
Copy Markdown
Member

Please, fix autotests first.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread inc/spbc-settings.php
@AntonV1211
AntonV1211 requested review from alexandergull and removed request for AntonV1211 August 24, 2026 12:42
@alexander-b-clean
alexander-b-clean merged commit 9aa7bea into dev Aug 26, 2026
5 checks passed
@Glomberg
Glomberg deleted the malware-scanning-text.ab branch September 2, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants