Security Firewall UI update - #700
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Firewall “Traffic Control Logs” UI row rendering to show a more informative location display and improve readability of request counters.
Changes:
- Replace “Country” cell rendering with a “Location” renderer that conditionally shows a flag and a clean
country/subdivision/citystring. - Format request counters with thousands separators for better readability.
- Rebuild/update the public React bundle to reflect the UI changes (and updated webpack runtime output).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| js/src/react/components/TabContent/TabFirewall/FirewallTableRow.js | Adds locale/location formatting helpers; updates the “Country” column to “Location” and formats numeric counters. |
| js/public/spbct-react-bundle.js | Regenerated bundle reflecting the UI changes and updated webpack runtime code paths. |
Comments suppressed due to low confidence (1)
js/public/spbct-react-bundle.js:2295
- The optional chaining operator (
document.currentScript?.) is emitted into the public bundle. If this plugin needs to run on older JS engines that don’t support optional chaining, the entire bundle will fail to parse. A simple null-check provides the same behavior without requiring optional chaining support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
value.toLocaleString('en-US'); to value.toLocaleString('S')
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
alexandergull
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/38882