Updating Grovers algorithm workshop#1526
Updating Grovers algorithm workshop#1526Alexandre-Classiq wants to merge 6 commits intoClassiq:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Alexandre-Classiq
force-pushed
the
alexandre-update-grover-workshop
branch
from
5e577b1 to
540c61a
Compare
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #7. hadamard_transform(x) # Prepare the minus state
The comment is inconsistent with the instruction (to prepare the plus state..)
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
QMOD -> Qmod
Drop the explicit name, it's not needed: x = QBit() in both 1 and 3
Use consistent tense: A variable that was declared -> A variable that is declared
you will always use Output for all variables -> you should use Output for all parameters
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
and then start a step-by-step build of it -> and then start to build it step-by-step
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
I think the proper wording is to reflect about some state (line, plane), not around. This phrase occurs in 7 more places below.
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
These first two sentences are very odd in style IMO. In particular, this is not about the "beauty of Classiq" (which is a company, and we can argue about its aesthetic qualities), but perhaps the power of the Qmod language, and the Qmod compiler.
How about the following -
Now we turn to actually implementing the oracle. With Qmod quantum expressions, capturing the intent becomes straightforward. The compiler does the heavy-lifting of synthesizing the reversible circuits for us.
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
The first sentence seems broken grammatically (incomplete?).
Also the second sentence is IMO cumbersome. Could clearer thus -
Here we want to apply a π phase to all states that are not equal our initial guess. The reflection operator (our diffuser) is defined as:
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
This sentence is again cumbersome IMO (and there's a grammatical error).
Improvement suggestion -
To implement a reflection about the initial state |psi0>, we instead perform a reflection about the computational zero state ∣0⟩, conjugated by our state-preparation unitary for the initial state |psi0>.
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
The term "squeeze" is fun, but potentially confusing (and technically inaccurate). It's conjugation, or applying an operator in a different basis.
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
I'm personally not crazy about the bombastic style in "harvest the fruits of the hard work"..
Reply via ReviewNB
2 participants
PR Description
Updating Grover's algorithm workshop