Skip to content

Remove prevent-migration-deletion job from build-and-publish job's needs#464

Merged
MattyTheHacker merged 5 commits intomainfrom
fix-build-and-publish-not-running
Apr 15, 2025
Merged

Remove prevent-migration-deletion job from build-and-publish job's needs#464
MattyTheHacker merged 5 commits intomainfrom
fix-build-and-publish-not-running

Conversation

@MattyTheHacker
Copy link
Copy Markdown
Member

@MattyTheHacker MattyTheHacker commented Apr 14, 2025

If it's determined that prevent-migration-deletion can run fine on pushes then this check can be added back and the if statement removed from the other job.

As it stands the build-and-publish job will never run on pushes to main

@MattyTheHacker MattyTheHacker added bug Something isn't working high priority Needs focus/attention as soon as possible labels Apr 14, 2025
@MattyTheHacker MattyTheHacker self-assigned this Apr 14, 2025
@CarrotManMatt CarrotManMatt added the deployment Changes to the deployment or CI/CD configuration label Apr 14, 2025
@CarrotManMatt CarrotManMatt changed the title Remove migration checks from build-and-push Remove prevent-migration-deletion job from build-and-publish job Apr 14, 2025
@CarrotManMatt CarrotManMatt changed the title Remove prevent-migration-deletion job from build-and-publish job Remove prevent-migration-deletion job from build-and-publish job's needs Apr 14, 2025
@CarrotManMatt
Copy link
Copy Markdown
Member

Cheers for catching this!

The prevent-migration-deletion job should only be run on PRs so that database migrations can always be deleted manually by overriding and pushing straight to main without a PR. It would be nice to make the needs for the build-and-release job conditional, so that the PR docker images are not built if the prevent-migration-deletion job fails, but there is no requirement to rely upon it when a push occurs. However, it is my understanding that setting that up would be very complex & hacky. Therefore, this solution is fine.

It will result in:

  • PR docker image containers will be built even if the prevent-migration-deletion job fails
  • PRs will still not be able to be merged if the prevent-migration-deletion job fails due to it being a required
  • The prevent-migration-deletion job will not be run for push events

@MattyTheHacker MattyTheHacker force-pushed the fix-build-and-publish-not-running branch from b35e388 to d1280a2 Compare April 14, 2025 21:16
@MattyTheHacker MattyTheHacker force-pushed the fix-build-and-publish-not-running branch from 564dad2 to d45ad93 Compare April 14, 2025 21:36
CarrotManMatt
CarrotManMatt previously approved these changes Apr 14, 2025
@MattyTheHacker MattyTheHacker enabled auto-merge (squash) April 14, 2025 23:06
@MattyTheHacker MattyTheHacker disabled auto-merge April 14, 2025 23:06
@MattyTheHacker MattyTheHacker merged commit 2b13ed5 into main Apr 15, 2025
8 checks passed
@MattyTheHacker MattyTheHacker deleted the fix-build-and-publish-not-running branch April 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deployment Changes to the deployment or CI/CD configuration high priority Needs focus/attention as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants