Strike system improvements#462
Conversation
CarrotManMatt
left a comment
There was a problem hiding this comment.
Just want to confirm you have considered the ephemerality of all of the responses in these new command. I see that there is a mix and I think we should err on the side of being ephemeral for displaying strike counts so that we don't end up unintentionally leaking it to be visible to non-committee members.
yeah this is a skill issue on my part, I intend to fix Soon:tm: |
|
No worries, cheers! |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the strike system by updating how strikes are incremented and adding new slash commands to query and decrement strikes.
- Updated strike increment logic to use Django's F expressions for a concurrency-safe update.
- Added two new slash commands: one for retrieving a user's strike count and another for decrementing strikes.
- Extended the deletion command group to support deleting all strike records in the database.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cogs/strike.py | Updated strike increment logic and added new slash commands for getting and decrementing strikes. |
| cogs/delete_all.py | Added a new command to delete all strike records from the database. |
|
This should be ready now, I couldn't figure out why the F string thing wasn't working so have changed it back |
As in wasn't working when running the bot on the dev testing discord server? Or just the comments that copilot made? |
|
tested too in the dev server and it actually didn't work, kept throwing this error: |
No description provided.