Annotation & Type Checking Fixes#445
Conversation
58f79f0 to
c04018f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR makes annotation and type checking fixes while also cleaning up various noinspection comments and minor docstring formatting issues.
- Updated the exported symbols in exceptions/committee_actions.py
- Removed redundant noinspection comments and improved minor docstring text across multiple files
- Adjusted logging and error handling messages for consistency
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| exceptions/committee_actions.py | Updated all to explicitly export relevant exception classes |
| exceptions/base.py | Removed redundant noinspection comments from abstract property definitions |
| db/core/models/utils.py | Updated docstring wording for consistency |
| db/core/models/managers.py | Removed noinspection comments and ensured consistent formatting |
| db/core/models/init.py | Added AssignedCommitteeAction to the module all and updated inline documentation |
| config.py | Revised docstrings and replaced logging.warning with logger.warning |
| Various cogs/*.py files | Removed noinspection comments and updated inline documentation for clarity |
|
Todo:
|
# Conflicts: # cogs/command_error.py # uv.lock
|
mostly looks good - but what does the mention string thing do? Can you not just do <@ROLE_NAME> and it does it automatically? |
It fetches the role object then uses the pycord property The previous code also used this dynamic mention retrieval, but the fallback code was on the call side rather than wrapped in this utility function for reuse. |
Suspended until #442 is merged